@nagyadam2092 opened this issue on February 16th 2016

Hello!

package.json is needed if someone wants to reach this repository via npm, so I added it. Please check the information I wrote there.

Thank you, Adam

@nagyadam2092 commented on February 18th 2016

any chance to merge this request soon?

@tsteur commented on February 18th 2016

In our bower.json we have some files to ignore specified. Like

"ignore": [
    "**/.*",
    "node_modules",
    "tests"
  ]

Is this possible with NPM as well? Or maybe we live the tests there as it will be only used for development via NPM. We always recommend to download the prepared ZIP file from piwik.org for deploying Piwik on production systems since it makes sure to remove test files and unneeded plugins etc.

Also, we might need to give some instructions on how to proceed with Piwik installation maybe? Eg Piwik won't work after fetching Piwik via NPM as it will be still needed to run Composer to fetch all PHP dependencies specified here. https://github.com/piwik/piwik/blob/2.16.0/composer.json#L38-L60

@mattab commented on February 20th 2016

(fyi @nagyadam2092 this FAQ lists instructions how to initialise Piwik when fetched from Git http://piwik.org/faq/how-to-install/faq_18271/ )

@mattab commented on March 14th 2016

Hi @nagyadam2092 could you maybe check the review/feedback above so we can consider merging your PR?

@mattab commented on July 25th 2016

Thank you for this proposed pull request.

Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit).

We hope you understand this and we look forward to seeing an update from you on this pull request or another one!

Thanks.

This issue was closed on July 25th 2016
Powered by GitHub Issue Mirror