@jpfleury opened this Issue on August 12th 2009

When we export a graph as an image, the page to which we are redirected doesn't contain any encoding declaration, so it can have some character encoding bugs, among other things with French sentences. For example:

<HTML>
<head>
<title>
Exporter au format Image
</title>
</head>
<body>
  <img title="Piwik Graph" src="data:image/[...]">
  <br>
  <br>
<p>
Pour enregistrer l'image sur votre ordinateur, faites un clic droit sur l'image et slectionnez "Enregistrer l'image sous..."
</p>
</body>
</html>

We should have at least a doctype and an encoding declaration. Example:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd ">
<HTML xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>
Exporter au format Image
</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
  <img title="Piwik Graph" src="data:image/[...]">
  <br>
  <br>
<p>
Pour enregistrer l'image sur votre ordinateur, faites un clic droit sur l'image et slectionnez "Enregistrer l'image sous..."
</p>
</body>
</html>
@pebosi commented on August 13th 2009 Contributor

Attachment: Created a little patch to add your proposals
piwik-926.patch

@robocoder commented on August 14th 2009 Contributor

In [1399], fixes #926 - add encoding to generated 'Export as image' page

@robocoder commented on August 16th 2009 Contributor

I introduced a regression. Fixed in [and 1406.

This Issue was closed on August 16th 2009
Powered by GitHub Issue Mirror