@kurakin opened this issue on August 5th 2009

I think, we should avoid of line breaks within the labels in some (not all) Tag Clouds views, especially in tables "Length of Visit" and "Pages per Visit". In the same time, line breaks within the labels in other Tag Cloud tables, such as "Visitor Browsers", "List of Keywords" and so on, should be allowed.

The proposed patch implements this behavior, offering the new table view property dont_break_labels. See before.png and after.png snapshots.

Take attention: this patch also offers little cosmetic improvement -- corrected line align in Tag Cloud. Left indents of lines are equal now (see snapshots).

@kurakin commented on August 5th 2009

Attachment: Avoid linebreaks within the labels in Length of Visit and Pages per Visit tag clouds, plus a little cosmetic change PiwikAvoidLinebreak.patch

@kurakin commented on August 5th 2009

Attachment: before.png

@kurakin commented on August 5th 2009

Attachment: after.png

@pebosi commented on August 13th 2009

i think the additional function "disallowLabelsBreak" could be unattended. just do it with css.

@kurakin commented on August 14th 2009

Replying to pebosi:

i think the additional function "disallowLabelsBreak" could be unattended. just do it with css.

I need to disallow linebreaks for two tables only: "Length of Visit" and "Pages per Visit". Linebreaks in all other tables should stay allowed. So I propose new property "dont_break_labels" to disable linebreaks selectively.

Thereto, disallowed linebreaks table can appears on the same page (dashboard) with allowed linebreaks table. These shouldn't affect each other. I don't no, how to solve it with pure css.

@robocoder commented on August 14th 2009

Would it be bad if we used the nowrap for all tag clouds?

@kurakin commented on August 16th 2009

Replying to vipsoft:

Would it be bad if we used the nowrap for all tag clouds?

It should be good enough for me at this time (I tried this about 3 mounths ago).

However, the original solution proposed in this ticket is just little more flexible. Who knows... may be in the future Piwik will have the tables with very long labels, requiring linebreaks anyway...

Though, at this time the simple solution -- nowrap for all tag clouds -- is satisfying for me too.

Thankee for your attention.

@robocoder commented on September 11th 2009

tackle in conjunction with #946

@robocoder commented on November 5th 2009

In [1567], fixes #905 - apply css changes

This issue was closed on November 5th 2009
Powered by GitHub Issue Mirror