@diosmosis opened this Pull Request on August 26th 2015 Member

This PR modifies the opt out form to always use a new window when setting the opt out cookies. This should work around all browsers that have issues w/ 3rd party cookies.

Note: This approach will break when some pop-up blockers are used.

Also Note: This PR is not complete.

Refs #8578

TODO

  • [x] Test in IE11.
  • [x] Test in Firefox.
  • [x] Test in chrome.
  • [x] Test in IE7, IE8, IE9.
  • [x] Test in Safari on OS X.
@diosmosis commented on August 30th 2015 Member

Ping @mattab Please give me your thoughts on the pop-blocker issue.

@mattab commented on August 31st 2015 Owner

Note: This approach will break when some pop-up blockers are used.

if tests work on all vanilla browsers (ie. PR Todo checklist) this is good to go, as it will work on all default configs and so for most people :+1:

@diosmosis commented on September 4th 2015 Member

Doesn't seem to work on chrome.

EDIT: Works on chrome, but if trusted host is not set for the Piwik URL, it leads to a hard to diagnose error.

@diosmosis commented on September 5th 2015 Member

@mattab @tsteur ready for review and/or merge.

@tsteur commented on September 7th 2015 Owner

Code wise looks okay to me, leaving the rest to @mattab I'm really not much into this topic and not sure re implication of popup blocker etc (which is enabled by default in most browsers nowadays?)

@mattab commented on September 8th 2015 Owner

Looks good to me! :+1: I will merge it and test it on demo2, if there is any problem with popup blockers we could revert this

@tsteur commented on September 8th 2015 Owner

Just out of interest... Does it work when JavaScript is disabled? I've never used it

@mattab commented on September 8th 2015 Owner

Amazingly, it does work with Javascript disabled :)

@mattab commented on September 8th 2015 Owner

Btw added the opt-out iframe in this page: http://piwik.org/privacy-policy/ (loading from demo.piwik.org which is running 2.15.0-b5)

This Pull Request was closed on September 8th 2015
Powered by GitHub Issue Mirror