@tsteur opened this Pull Request on August 19th 2015 Owner

refs #8593

configuration didn't change. It works as before: [Tracker]debug=1

@mnapoli commented on August 19th 2015 Member

StreamHandler could be used instead of writing a custom Monolog adapter (new StreamHandler('php://stdout'))?

@tsteur commented on August 19th 2015 Owner

I thought about using StreamHandler initially but then it's more work configuring it etc and the code of streamhandler looks complicated so rather went with the simple two liner

@tsteur commented on August 19th 2015 Owner

We currently send header text/plain... which results in HTML not being parsed. Is it ok? I'd kinda prefer it like this to prevent any possible injections in case someone has debugging enabled. Can do a strip_tags or so

trackerlog

@mattab commented on August 19th 2015 Owner

I'd kinda prefer it like this to prevent any possible injections in case someone has debugging enabled.

Security is the main reason the text/plain header was set :+1:

@tsteur commented on August 19th 2015 Owner

strip_tags then? I kinda do not really mind the html markup there. One can still copy/paste it and make it readable

@mattab commented on August 19th 2015 Owner

I kinda do not really mind the html markup there. One can still copy/paste it and make it readable

:+1:

This Pull Request was closed on August 20th 2015
Powered by GitHub Issue Mirror