@szepeviktor opened this issue on August 6th 2015

Could you please exclude .phpstorm.meta.php and other development files for e.g. Composer?

@szepeviktor commented on August 6th 2015

Do you keep your release script in this repo? I would send a PR.

@mnapoli commented on August 7th 2015

Thank you, I've created a pull request: https://github.com/piwik/piwik-package/pull/34 The release script is indeed in a separate repository.

@szepeviktor commented on August 7th 2015

Thank you. Are Bower and Composer files needed in production?

@mnapoli commented on August 7th 2015

For Bower and Composer I have to say honestly I'm not so sureā€¦ I would say no but since they are kept in the release there might be a reason for it. Ping @mattab who might have an answer.

@szepeviktor commented on August 7th 2015

@mattab Could you please help us? Are Bower and Composer files needed in production?

@tsteur commented on August 7th 2015

They should not be needed at the moment and could be removed - if needed.

@szepeviktor commented on August 7th 2015

I prefer clean production packages.

@mattab commented on August 7th 2015

What's the matter with composer files? I think they provide some value, showing Piwik users all libraries bundled with Piwik, eg. for security reasons this may be useful?

@szepeviktor commented on August 7th 2015

OK. I delete every file in piwik root which are for no use in production (for security reasons because all of them can be downloaded) This way I have to delete these files on every update.

@szepeviktor commented on August 7th 2015

showing Piwik users all libraries bundled with Piwik

Do you think more than 0.1% of the users are familiar with e.g. composer?

This issue was closed on August 7th 2015
Powered by GitHub Issue Mirror