@tsteur opened this issue on July 30th 2015

fixes #7692

This worked for me. Can someone please try as well? Sometimes I can still see something like tocomplete for a second but it should be shown correctly immediately after.

@mnapoli commented on July 30th 2015

Can still see HTML code appear when typing.

Also there is this kind of encoding issue:

Whereas the name of the site is:

Other example:

@mnapoli commented on July 30th 2015

Also given the obscure nature of the fix, it would be great to document it (unless another solution is applied given it doesn't solve all the problems). I don't expect anyone reading that code in a few weeks to understand why the "priority: 10".

@tsteur commented on July 30th 2015

As mentioned it can be still visible for like half a second or so but should be quickly displayed correct. Obscure nature of the fix? Do you mean the priority? Priorities are a common thing in angular and not really obscure I'd say. Can leave a comment though.

Will have a look re the problem if the search term is eg lt

@tsteur commented on July 30th 2015

Pushed another commit

@mnapoli commented on July 30th 2015

Do you mean the priority? Priorities are a common thing in angular and not really obscure I'd say. Can leave a comment though.

priority: 10, // makes sure to render after other directives

The concept of priority is obvious, what's less obvious is why it's important to render after the other directives. That's what won't be obvious to someone landing on that code in a few weeks/months/years.

@tsteur commented on July 30th 2015

I'm not sure what to comment there. It should simply run last otherwise it could be overwritten again by another directive. Eg in my case the colors / autocomplete match was often not visible. That's why there's a priority set indicating it should run after other directives. I can link to this PR if it helps

@mattab commented on August 13th 2015

Well done, looks fixed!

This issue was closed on August 13th 2015
Powered by GitHub Issue Mirror