@energynumbers opened this Pull Request on July 23rd 2015 Contributor

Old naming method for constructors (same name as class) is deprecated as
of PHP7

@sgiehl commented on July 24th 2015 Member

As that is a third party lib, we should not do any changes without mentioning them in README.md

Btw. in my opinion it would be a better way to find a good alternative to the old sparkline library we are using. Maybe we could also write a short implementation for our needs, and remove that external lib.

@tsteur commented on July 27th 2015 Owner

If that sparkline lib is no longer maintained, looking for a new one sounds good :+1:

@jcracknell commented on August 5th 2015

How about generating an <svg:path>?

@sgiehl commented on August 5th 2015 Member

svg is an option for sure, but we still need to be able to generate them as an image. Otherwise we can't use them in email/pdf reports and the mobile app.

@mattab commented on August 9th 2015 Owner

Targeting to 2.15.0 as it would be appreciated for users if we support PHP7 in Piwik 2.X branch :+1:

@mattab commented on August 9th 2015 Owner

As that is a third party lib, we should not do any changes without mentioning them in README.md

Thanks @energynumbers for the pull request. do you mind adding a notes in libs/README.md about your modification? then we can merge the pull request, cheers

This Pull Request was closed on August 12th 2015
Powered by GitHub Issue Mirror