@sgiehl opened this Pull Request on July 11th 2015 Member

fixes #8321

@mattab commented on July 12th 2015 Owner

Imho returning the empty value would be correct here, but I guess that might break other stuff in piwik to change that behavior.

If you think it would be correct behavior, maybe it's worth trying the correct fix and see if all our tests would still pass? it may be a bit risky but in general it's worthwile trying the "Correct fix approach" in case it may just work :-)

And kuddos for this PR! :+1:

@sgiehl commented on July 12th 2015 Member

Maybe we should not try to do that for a minor fix version.... But I could
try to change that after 2.14.1 was released.

@mattab commented on July 12th 2015 Owner

Makes sense to limit risk for 2.14.1 :+1:

@mattab commented on July 12th 2015 Owner

looks good, thanks for looking into this regression @sgiehl

Added tiny commit https://github.com/piwik/piwik/commit/1b30b7fbe9720b5de758b790d422ee57d1556716

This Pull Request was closed on July 12th 2015
Powered by GitHub Issue Mirror