The text changes proposed in #7836 were fairly simple. I added one new translation key,
Goals_NeedAccess, because the existing translation key (
Goals_NoGoalsNeedAccess) assumes you don't have a Goal for a given website.
Thanks for the pull request!
I also duplicated _addEditGoal.twig and _listGoalEdit.twig, and modified them to make _viewGoal.twig and _listGoalView.twig.
In general duplicated code is not something we can accept at any cost in Piwik. Duplicated code is a common anti pattern of software engineering and there is always a better way to solve a problem by refactoring the code. If you understand this, please feel free to modify the pull request accordingly. Cheers
Please let me know if you have any other comments, I appreciate anything that helps me contribute higher-quality code :)
Thanks @spacenate for updating your PR :-) we will review it for 2.15.0
Looks good to me. @spacenate Can you rebase your branch? I will merge afterwards.
Hi @diosmosis, happy to!