@barbushin opened this issue on July 2nd 2015

Closes #8244

@tsteur commented on July 2nd 2015

I still have to click on the select for the changes to be applied, even after I changed the value.

Just had a quick look and it might be enough to listen to the change instead of click event here:

https://github.com/barbushin/piwik/blob/8244_goals_form_fix/plugins/Goals/javascripts/goalsForm.js#L108

That might be the only change needed but not sure re side effects. If that works, we could undo the other changes probably.

@barbushin commented on July 3rd 2015

Changed .click to .change, but for me it works the same. Like this http://i.imgur.com/gKzOzt0.gif

@tsteur commented on July 5th 2015

Which browser are you using? It did not work for me on Chrome 43 with MacOSX.

@mattab the select box is now moved to the right see: http://i.imgur.com/gKzOzt0.gif What's your thought on that?

@barbushin commented on July 6th 2015

I use Chrome 43, Firefox 34 and Opera 12 on Win8.1x64.

Regarding new select box position, I moved it to the right side because I thought it's HTML bug that it was located in left side. Also I think it will be better if we set vertical-align: top for blocks titles, like this http://i.imgur.com/yV4VIPb.png (current version: http://i.imgur.com/uoytH0r.png).

But anyway, it's up to you, guys, to chose the best solution. I'm not a designer :)

@mattab commented on July 6th 2015

I'm not a designer :)

we're also not designers, but we do our best to build UI that look good and are usable. it's very important part of building a successful and amazing product.

@barbushin

Could you add some space below this SELECT box as you can see it's too close to the radio boxes below

@barbushin commented on July 6th 2015

@mattab What browser do you use? In Chrome 43 and Firefox 34 there is a space already

@tsteur commented on July 6th 2015

Also I think it will be better if we set vertical-align: top for blocks titles

I like it much better, maybe you can issue another PR?

@barbushin commented on July 6th 2015

@tsteur Sure! Just added that fix in https://github.com/piwik/piwik/pull/8279

@mattab commented on July 7th 2015

@mattab What browser do you use? In Chrome 43 and Firefox 34 there is a space already

@barbushin I can see this behavior on both latest Chromium and Firefox on ubuntu

@barbushin commented on July 7th 2015

@mattab It's very strange because I can't reproduce it. There is <p> tag with margin-top: 10px for list of radio inputs

This issue was closed on July 6th 2015
Powered by GitHub Issue Mirror