@barbushin opened this Pull Request on July 1st 2015 Contributor

Closes #7298

@mattab commented on July 1st 2015 Owner

Feedback:

  • add a unit test for this method to show that it really closes #7298 and that it validates email addresses properly
@barbushin commented on July 1st 2015 Contributor

@mattab Done

@barbushin commented on July 1st 2015 Contributor

@diosmosis I've renamed test methods, and changed test parent class to PHPUnit_Framework_TestCase. Thanks for that review!

@barbushin commented on July 3rd 2015 Contributor

Moved Zend_Validate_EmailAddress to DI. Now it's ready to merge?

@barbushin commented on July 5th 2015 Contributor

It was a wrong old test method UsersManagerTest::testAddUserWrongEmail() that asserted that ema'il<a class='mention' href='https://github.com/email'>@email</a>.com is invalid, but regarding RFC and new email validator(and http://isemail.info) ema'il<a class='mention' href='https://github.com/email'>@email</a>.com is valid.

array('mx' => false, 'deep' => false) are default settings for Zend_Validate_EmailAddress so I think we can just forget about it.

This Pull Request was closed on July 6th 2015
Powered by GitHub Issue Mirror