@mnapoli opened this Pull Request on June 19th 2015 Member

In the process of getting rid of UnitTestCase that sets up a complete environment, I have changed all tests that extend it:

  • those that were real unit tests are now extending PHPUnit_Framework_TestCase
  • those that were using the global state are moved to integration tests

As a result unit tests are much faster (not because there are less tests, but because there is never an environment set up. To give an idea a test class extending UnitTestCase would run in 2-5s, and without it would run in 100ms.

Locally unit tests have gone from 21s to 6s (no xdebug, no-globals-backup). Judging from travis integration tests are not longer.

The build is green, only UI tests are failing.

@mattab commented on June 22nd 2015 Owner

:+1:

This Pull Request was closed on June 19th 2015
Powered by GitHub Issue Mirror