@mnapoli opened this issue on April 15th 2015

See #7614

Archiving with --force-all-websites now shares the site list. That allows to run a second archive process which will reuse the same (shared) site list.

To avoid a normal archiver sharing the site list with an archiver using --force-all-websites, we store the shared site list in a different option.

To sum up:

# share the same site list
./console cron:archive
./console cron:archive

# share the same site list
./console cron:archive --force-all-websites
./console cron:archive --force-all-websites

# don't share the same site list
./console cron:archive
./console cron:archive --force-all-websites
@diosmosis commented on April 15th 2015

Verified that this works as expected. Once the single review comment is dealt w/, it can be merged.

@mnapoli commented on April 15th 2015

Done, moved the code to a private method

@diosmosis commented on April 15th 2015

I was hoping you'd also clear up the logic a bit. I find it a bit confusing, and since you're in there, you could do some cleaning. Eg, if the if/elseif is split up, the first && SharedSiteIds::isSupported (or whatever) would be redundant and could be removed.

@mattab commented on April 16th 2015

FYI @mgazdzik we changed the meaning of --force-all-websites so it always uses a shared queue

@mattab commented on April 16th 2015

@mnapoli could you update the --force-all-websites param documentation to explain the ilst will be shared across multiple processes?

@mnapoli commented on April 16th 2015

@mattab done

This issue was closed on April 15th 2015
Powered by GitHub Issue Mirror