@mnapoli opened this Pull Request on April 6th 2015 Member

Fixes #7345

capture d ecran 2015-04-06 a 13 12 55

@mattab commented on April 7th 2015 Owner

Feedback

  • did you try to write (edit goal) instead of the icon? otherwise it may feel like "icons overload" (it was discussed in issue)
@mnapoli commented on April 7th 2015 Member

Yes I tried and it looked weird and overloaded. In the issue there are no reasons given why not to use icons, maybe there's another issue somewhere where it's discussed?

@mattab commented on April 9th 2015 Owner

it doesnt look awesome, but it's a small part of the app, and it's a useful shortcut to let users edit goals, so +1

maybe others have suggestions?

@diosmosis commented on April 9th 2015 Member

I think some text would be useful, otherwise I wouldn't assume the icon is for editing goal, so much as editing for the header text.

@mnapoli commented on April 9th 2015 Member

I'll work on a solution with a text link + a screenshot

@diosmosis commented on April 9th 2015 Member

Nice goal, btw :)

@mnapoli commented on April 10th 2015 Member

Comparing the 2 options:

capture d ecran 2015-04-06 a 13 12 55

capture d ecran 2015-04-10 a 17 21 41

Any other idea?

@diosmosis commented on April 10th 2015 Member

Not sure how it would look, but maybe a right aligned link that says (edit goal) or (edit goal details)?

@mnapoli commented on April 10th 2015 Member

Aligned to the right of the screen? Here the screenshot is truncated but on a large screen it would be really far from the title (all alone on the right).

@diosmosis commented on April 10th 2015 Member

That's what I was thinking of (far to the right). This may not apply to others, but associating an edit link with the title for goal reports, rather than something directly related to the goal seems odd to me. I'm not a UX expert though.

Maybe <small>ed and surrounded with () and left aligned? Just spitballing here.

@tsteur commented on April 17th 2015 Owner

What about the suggestion of @Bugsbane in https://github.com/piwik/piwik/issues/7345#issuecomment-90761253 . He suggested to add a menu link "Manage Goals" before "Add a new Goal". Reckon this would be most clear and visible.

@mattab commented on April 17th 2015 Owner

add a menu link "Manage Goals" before "Add a new Goal". Reckon this would be most clear and visible.

+1 - not sure why we didn't do it in the first place

@mnapoli commented on April 17th 2015 Member

OK closing this then

This Pull Request was closed on April 17th 2015
Powered by GitHub Issue Mirror