@sgiehl opened this Pull Request on April 5th 2015 Member

This PR aims to fix #7444 and adds the possibility to exclude an extension from the list of "download extensions".

It also converts the list of already excluded extensions into an array and resolves the regexes to single values, so it is possible to remove only some of them.

Methods for setting, adding and removing extensions now accept single values as well as multiple values (as array or separated by "|")

@mattab commented on April 7th 2015 Owner

Feedback

  • Looks good!
  • could you add some unit tests in tests/javascript/index.php?
  • after merge, we will need to update the Javascript client doc
@sgiehl commented on April 7th 2015 Member

I've added some tests.

@mattab commented on April 9th 2015 Owner

looks good to me, merging :+1:

@mattab commented on April 26th 2015 Owner

Hi @sgiehl, just remembered we didn't update the developer documentation at: https://github.com/piwik/developer-documentation/blob/master/docs/tracking-javascript.md - would you mind documenting the new method there?

@sgiehl commented on April 27th 2015 Member

Sorry. I somehow thought the documentation is some kind of autogenerated. I've updated the doc in https://github.com/piwik/developer-documentation/commit/1794b90a2f8b95b2aef0812bfeaf66811a64edac

This Pull Request was closed on April 9th 2015
Powered by GitHub Issue Mirror