@robinsherwood opened this issue on April 1st 2015

Discussion: http://forum.piwik.org/read.php?2,125778 The ZIP folder is missing the tmp folder. This seems to be a bug. Now the tmp folder is created by piwik - undeletable :(

@mattab commented on April 1st 2015

Thanks @robinsherwood for report.

we used to package the tmp/ folder but seems not the case since 2.10.0 or so -

Tasks - add back tmp folder with .gitkeep file - add unit test to make sure the tmp/ folder is there in Piwik

@mnapoli commented on April 2nd 2015

I've pushed the folder back, which permissions was it supposed to be, 755?

@robinsherwood commented on April 3rd 2015

In my active running install it is 755

@mattab commented on April 7th 2015
  • I'm not sure now what it should be but it's important to set same permission as it was before it was removed
  • let's add an automated test that will detect in case the folder is missing in the future
@mnapoli commented on April 7th 2015

The test was added in the commit already.

I've downloaded Piwik 2.9.0 and the permissions are 755, so I'll apply those permissions.

@mnapoli commented on April 7th 2015

Turns out that git doesn't store permissions, so it's now just like it was before.

@mattab commented on April 20th 2015

@mnapoli could you add a unit test to verify the tmp/ folder is in git? i'm afraid otherwise we may delete it again without noticing.

@mattab commented on April 20th 2015

Ok I see now that the test exists already in https://github.com/piwik/piwik/commit/2f524cccc39b6326b2ad664b63aa21eb7e7c566c :+1:

@mnapoli commented on April 20th 2015

yes that's what I said in the comment above ;)

This issue was closed on April 7th 2015
Powered by GitHub Issue Mirror