Drop styling. Developers will apply their own theme anyways. - Drop <style>...</style> from output - Remove <b></b> tags - Drop border and width attributes from <table> definition
Recommended changes: - Enclose attribute values in double quotes. - Separate header and body using <thead></thead> and <tbody></tbody> - Set table id, e.g., id="Actions_getActions" - Instead of "Sub DataTable not loaded", add a pseudo-column that contains an integer (idSubtable)
Improvements: - Add example using the jQuery DataTables plugin
Depends on #772
(In ) fixes #760 - changes to Basic HTML format
(In ) refs #760 - use <th> for header
Reopening: - before the html output was a simple debug output; now it seems it will be part of the feature as your examples suggest: it makes it very easy to reuse the data in external apps. As such, we need to add unit test to the output of this table, just like other format are tested in tests/core/DataTable/Renderer.test.php - how could we best showcase this new feature? It looks like something that could be very useful to many people integrating Piwik in their project.. I would suggest a short and sweet blog post tutorial explaining how to do so - just an idea :-) but would definitely advertise this to the community - could we also include it in misc/? - you mention "flot", is it in the screenshots attached to the ticket?
$value = html_entity_decode($value, ENT_COMPAT, 'UTF-8'); $value = htmlspecialchars($value);
I would instead suggest to use Piwik_DataTable_Filter_SafeDecodeLabel to keep this logic in one place only.
Closing in favor of #804; test case will be included in #772
Note: dataTable.html is a proof-of-concept; in practice, the data would be embedded in the page from the server-side so that token_auth is not exposed in the page source