Improves performance for
Fixed bugs in LabelFilter, ReportsTotalCalculation, Sort and more.
A new feature is that we do now actually sort API output by
nb_visits, labels by default which was often not the case. Also we do now sort by labels if both columns do not have a value. Eg if two rows do not have
nb_visits or any other
filter_sort_column then the order was random. We do now sort by label in such a case.
I didn't create a pull request for each fix separately since they only shows after tweaking some code and where not really visible before.
A few UI tests fail since we do now sort by label if two rows have both no value set. See eg http://builds-artifacts.piwik.org/ui-tests.datatable_tweaks/11069.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/PivotByDimension_pivoted.png&expected=PivotByDimension_pivoted.png&github=PivotByDimension_pivoted.png
For more information see my comments in the code. It would be kinda nice to have this in 2.12.0 since it brings many performance improvements.
Looks good to me :+1: merging