@sgiehl opened this Pull Request on March 14th 2015 Member

This PR aims to fix #6176

Currently the visitor log looks like that:

visitorlog_before

As the browser plugins are not relevant for every one and some users asked to have the full location information instead, I now added the possibility to see all information. I've also added a new icon for the device type. Overall it now looks like that:

visitorlog_after

By default only the icons are displayed without any additional informationen. But it is now possible to hover the small icons to see more information:

visitorlog_flag_hovervisitorlog_browser_hovervisitorlog_device_hover

In order to have all information available in the visitor log, I had to adjust the information available in the visitor details. They now additionally contain deviceTypeIcon, deviceBrand and deviceModel

@mnapoli commented on March 15th 2015 Member

That's a really cool improvement!

@mattab commented on March 16th 2015 Owner

Nice improvements!

  • +1 for the new icon for device type
  • +1 for hiding the plugin icons (too much noise!)
  • +1 for more information (ie. full information!) to the user on request (that's really great and part of our vision to give users all the data when they need it, and not hide anything from them)
  • -1 for "transparent" icons - can we try with the full opacity icons instead?

BTW it's very good to improve the Visitor Log in general, because that's one of the most used and loved features in Piwik :-)

@sgiehl commented on March 16th 2015 Member

@mattab Ok. I've adjusted the changelog and moved it to new topic "API Improvements" for Piwik 2.13.
Regarding the "transparent" icons: The opacity is removed on hover, so the user get's a little feedback that something is happening. But that could be removed for sure, or should I just increase the opacity value. It currently starts at 0.5. Do you think starting at 0.7 would be better?

@mattab commented on March 16th 2015 Owner

I think it's better to remove the opacity... if we wanted to show feedback on hover...

  1. maybe we could use the existing UI pattern on the Report footer icons, ie. add a grey background behind the icon. I guess it may look bad because many Visitor log icons don't have transparent background....
  2. Another idea would be to draw a thin border on hover
@sgiehl commented on March 17th 2015 Member

Ok. I've removed the opacity. Adding border or grey background didn't look very good, cause of different icon sizes

@mattab commented on March 18th 2015 Owner

Here is feedback looking at UI tests:

  • the "Goal conversion" icon (flag) is pushed out of display sometimes (not a regression). Can we add a linebreak before showing this icon to give it full display? eg. this ui test
  • could we make the popover a bit wider by default? (general issue in piwik)
@sgiehl commented on March 22nd 2015 Member

I've tried to fix the layout problem with the icons. Let's see if the ui tests look better now :)
Regarding the Popovers: Maybe we should open another issue for that, as that will break more ui tests.

@mattab commented on March 23rd 2015 Owner

Regarding the Popovers: Maybe we should open another issue for that, as that will break more ui tests.

Sure it is: #7517

@mattab commented on March 30th 2015 Owner

Looks good to me! we'll need to update screenshot tests as the UI build failed in the PR

This Pull Request was closed on March 30th 2015
Powered by GitHub Issue Mirror