@diosmosis opened this Pull Request on March 7th 2015 Member

Updated version of this pull request: https://github.com/piwik/piwik/pull/6793

@piwik/core-team Ready for review.

@mattab Not sure what milestone to put this in?

@mnapoli commented on March 8th 2015 Member

misc/others/geoipUpdateRows.php was removed: are users using it and will they be confused?

@mattab commented on March 8th 2015 Owner

misc/others/geoipUpdateRows.php was removed: are users using it and will they be confused?

+1 maybe we can simply output a text like the script was moved - please use this new command instead "./console ....

Also we'll need to update the FAQ https://piwik.org/faq/how-to/faq_167/

@diosmosis commented on March 11th 2015 Member

If build passes, should be ready for another review and/or merge.

@diosmosis commented on March 16th 2015 Member

@mattab Feel free to take another look or merge.

@mattab commented on March 16th 2015 Owner

@diosmosis the build is failing with some rounding errors on MYSQLI: https://travis-ci.org/piwik/piwik/jobs/54514265

@diosmosis commented on March 16th 2015 Member

@mattab Mysqli issues fixed.

EDIT: UI test failure is random fail.

@mattab commented on March 17th 2015 Owner

please confirm when you have tested it on a real database to check that visits are geo located correctly.

Once confirmed, :+1: for merging this!

This Pull Request was closed on March 17th 2015
Powered by GitHub Issue Mirror