@anonymous-piwik-user opened this Issue on May 16th 2009

The piwik.org wordpress stylesheet does not define a background color. Patch attached, please fix.

@anonymous-piwik-user commented on May 16th 2009

Attachment:
style.patch

@anonymous-piwik-user commented on May 16th 2009

Attachment: Screenshot of problem
screenshot8.png

@robocoder commented on May 16th 2009 Contributor

I think you need to pass this along to the WP plugin author.

Piwik does set the background colour in themes/default/simple_structure.css

@anonymous-piwik-user commented on May 16th 2009

vipsoft: This is not about the WP plugin and not about Piwiki. This is about the piwik.org website (see the screenshot).

@robocoder commented on May 16th 2009 Contributor

sorry too early in the a.m.

what browser are you using?

@anonymous-piwik-user commented on May 16th 2009

No problem.

I'm not the reporter of the bug, but you can reproduce the bug in any browser. Just set the default background colour to something else than white. The patch provided by the reporter will fix the problem by setting white as the background colour of the page in addition to the background image.

@robocoder commented on May 16th 2009 Contributor

that sounds counter intuitive... if the user has changed the default background color in their browser config, isn't the right approach to respect that (even if it looks bad)?

@anonymous-piwik-user commented on May 16th 2009

Yes, you should respect the default settings of the browser. But: If you set a foreground colour (i.e. text colour) you need to set the background colour, too.

Suppose one likes white text on black background. While not everyone's taste, you can still read it. So if a web page does not set either background colour or foreground colour, you're fine with this default setting.
Now consider this: A web page does not set background colour, but sets text colour to black. You end up with black text on black background. The result: Unreadable.

Piwik.org sets a foreground colour. That's why it should set a sensible background-colour, too.

@anonymous-piwik-user commented on May 16th 2009

Comment 6 by feyp is absolutely right. If you define one colour (text or background) you have to define the other too or bad things may happen, see the screenshot for an example.

This is a common problem all over the internet, but only few people (like me) notice it.

@mattab commented on May 18th 2009 Owner
@anonymous-piwik-user commented on May 18th 2009

nice, thanks very much

This Issue was closed on July 30th 2009
Powered by GitHub Issue Mirror