@mattab opened this Issue on May 11th 2009 Owner

currently we don't check that the user has the zlib extension, but it is required for piwik to work correctly. We should add this check at installation.

@pebosi commented on May 25th 2009 Contributor
@pebosi commented on May 25th 2009 Contributor
@pebosi commented on May 29th 2009 Contributor

Attachment: next try
700_gd_systemcheck.patch

@pebosi commented on May 30th 2009 Contributor

Attachment: added spl check
700_spl_systemcheck.patch

@pebosi commented on June 2nd 2009 Contributor

Attachment: updated patch
700_spl_systemcheck.2.patch

@pebosi commented on June 2nd 2009 Contributor

Attachment: updated template file, no patch
systemCheck.tpl

@pebosi commented on June 2nd 2009 Contributor

Attachment: patch for template file
700_systemcheck_template.patch

@pebosi commented on May 25th 2009 Contributor

added a patch to check extensions array for zlib.

@pebosi commented on May 25th 2009 Contributor

i created another patch to reduce some code, only a suggestion... (if useful i will modify template too)

regards

@robocoder commented on May 28th 2009 Contributor

pebosi: it looks good with the exception of the changes from lines 488-499. It looks like the version requirement has been reversed; meanwhile, there's no check when the gd extension is missing.

@pebosi commented on May 28th 2009 Contributor

my last patch also removes traling spaces...

@mattab commented on May 29th 2009 Owner

pebosi, your patch is hard to read as you removed all white spaces etc.
can you please submit patch against trunk for only the lines you modified?

@pebosi commented on May 29th 2009 Contributor

added patch version without removing whitespaces

@mattab commented on May 30th 2009 Owner

assuming it has been tested, looks good to me

@mattab commented on May 30th 2009 Owner

actually we should also add SPL to the list of required extension as of #176

@robocoder commented on June 1st 2009 Contributor

Looks good (except for some minor formatting). Can you update the systemCheck template too and test it?

@pebosi commented on June 2nd 2009 Contributor

attached an updated patch and the first version of tempalte file (no patch). i replaced the help text of gd and extension-check with a link to http://piwik.org/docs/requirements/ (needs to be updated then)... only a suggestion ;)

regards

@robocoder commented on July 3rd 2009 Contributor

Sorry for not reviewing this sooner.

  • Controller.php: ereg should be replaced with preg_match() for php 5.3
  • systemCheck.tpl: one link to http://piwik.org/docs/requirements/ should be sufficient
  • lang/en.php needs to be updated

We should add/keep the informative help messages (e.g., Installation_SystemCheckPdoHelp). Perhaps:

$needed_functions = array(
    'set_time_limit' => 'Installation_SystemCheckTimeLimitHelp',
    'mail'           => 'Installation_SystemCheckMailHelp',
);
@robocoder commented on August 5th 2009 Contributor

(In [1368]) fixes #700 - added check for zlib and SPL at install; based on pebosi's patch

This Issue was closed on August 5th 2009
Powered by GitHub Issue Mirror