@czolnowski opened this Pull Request on January 5th 2015 Contributor

Hello team,

I remove hardcoded class name and replace them with hook. I suppose that is more universal and easier to maintain than path to EnterpriseAdmin plugin class.

@tsteur commented on January 22nd 2015 Owner

I do not really understand this change. Do you mind explaining why we need to events to detect and filter commands? In theory people could add their own commands using the filterCommands event if needed (which would be probable only the Enterprise plugin). Normal expected behaviour would be that plugins place the Command in the correct folder. If I remember correct Enterprise plugin was a special case as it is used when Piwik is not yet installed or so? So using the filterCommands event here seems ok for me

@mattab commented on February 7th 2015 Owner

Hi @czolnowski is this PR in progress, maybe you have a question? if not feel free to close

This Pull Request was closed on February 10th 2015
Powered by GitHub Issue Mirror