@mnapoli opened this Pull Request on January 1st 2015 Member

This PR is based on #6909 which explains the commit history and the big diff.

I've moved data files related to internationalization into the new Intl component (introduced in #6909) just like in Symfony's Intl component.

Previously, those data files were manually included, and $GLOBALS was used. Now it's been replaced with classes.

capture d ecran 2015-01-01 a 13 27 14

@mnapoli commented on January 5th 2015 Member

All good for review and merge after #6909 is merged!

@mnapoli commented on January 5th 2015 Member

The tests pass on Travis but on 5.3.3 the sh script ends with a segfault :/ I have no idea what's going on, everything seems fine (tests are all OK)

@mattab commented on January 5th 2015 Owner

needs to be rebased, Looks good to me!

@mnapoli commented on January 8th 2015 Member

Please review the last commit (de53c1b306): it solved the eternal "MySQL server has gone away" (at least here). If OK, then it's good to be merged.

@mattab commented on January 9th 2015 Owner

:+1:

This Pull Request was closed on January 9th 2015
Powered by GitHub Issue Mirror