@mnapoli opened this Pull Request on December 22nd 2014 Member

We have the following entry points for the application:

  • index.php
  • console
  • piwik.php
  • js/tracker.php
  • misc/cron/archive.php
  • tests/PHPUnit/bootstrap.php
  • tests/PHPUnit/proxy/*.php
  • tests/resources/staticFileServer.php

And there's of course a lot of duplicated code in them.

I've tried to identify the common logic and put it in a core/bootstrap file.

This is a PHP file, not a class, because it needs to be PHP 4 compatible. If you see a better way than this I'll gladly consider it, I'm not against having a raw PHP file but having a Bootstrap class would allow to use private methods and eventually we might move the configuration of the container in there.

@mattab commented on December 28th 2014 Owner

+1 for consistency!!

This Pull Request was closed on December 28th 2014
Powered by GitHub Issue Mirror