@tsteur opened this issue on November 12th 2014

Reverts piwik/piwik#6574

See #6636

@mattab commented on November 12th 2014

A revert button?! This is so cool !!!

@tsteur commented on November 12th 2014

I tried it with PHP 5.3 and the fatal errors as well as "Constant already defined" messages are fixed now.

Still getting those error message not sure what it is about:

FERROR UserCountry[2014-11-12 03:53:39] GeoIPAutoUpdater: Encountered PHP error when performing redundant tests on GeoIP isp database: 256: error traversing database - perhaps it is corrupt? on line 642 of /home/vagrant/www/piwik/libs/MaxMindGeoIP/geoip.inc.
ERROR UserCountry[2014-11-12 03:53:39] GeoIPAutoUpdater: Encountered PHP error when performing redundant tests on GeoIP org database: 256: error traversing database - perhaps it is corrupt? on line 642 of /home/vagrant/www/piwik/libs/MaxMindGeoIP/geoip.inc
@joostdekeijzer commented on November 13th 2014

@tsteur Do you have the GeoIP PECL extension installed when you run the tests?

The travis tests also run on php5.3 and it doesn't have any fatal errors ( https://travis-ci.org/piwik/piwik/builds/40490769 )

@joostdekeijzer commented on November 13th 2014

And the errors you mention are "correct". The UserCountryTest::testGeoIpUpdaterRedundantChecks() checks if broken GeoIP files are renamed. That method creates broken (empty) ISP and ORG GeoIP files.

The error you see is from the GeoIPAutoUpdater class finds a broken file. Maybe that output can be muted, I don't know...

@mattab commented on November 14th 2014

Maybe that output can be muted

+1 I think we should be able to mute them in those tests only since we expect the warning there. feel free to remind us of this in your Pull request :)

ping @diosmosis

This issue was closed on November 13th 2014
Powered by GitHub Issue Mirror