@PierreLvx opened this Pull Request on October 31st 2014

Crunched GIFs and PNGs, approx. 320kb saved (lossless).

@PierreLvx commented on October 31st 2014

The one and only failure I can see in the logs is gif format failed for following icons gimp /home/travis/build/piwik/piwik/plugins/Referrers/images/searchEngines/xx.gif, if that's any help.

@mattab commented on November 3rd 2014 Owner

Hi @PierreLvx thanks for the pull request! That sounds like a useful change.

I wanted to be sure the compression was really lossless. How did you convert all the files, did you use a command on terminal?
cheers

@PierreLvx commented on November 3rd 2014

Hi @mattab! I simply used ImageOptim, which bundles a number of CLI tools.

It optimizes compression parameters, removes junk metadata and unnecessary color profiles.

ImageOptim seamlessly integrates the best optimization tools: PNGOUT, Zopfli, Pngcrush, AdvPNG, extended OptiPNG, JpegOptim, jpegrescan, jpegtran, and Gifsicle.

I also noticed there're some duplicate images. Perhaps these could be taken care of in a future task/PR.

@mattab commented on November 3rd 2014 Owner

I simply used ImageOptim, which bundles a number of CLI tools.

Nice to learn of this cool GPL licensed tool!!

feedback:

  • could you exclude the /libs folder as it's not our own code and we prefer not to change third party code directly
  • plugins/Referrers/images/searchEngines/xx.gif maybe revert this file if it fails the test as i'm not sure why
@PierreLvx commented on November 4th 2014

could you exclude the /libs folder as it's not our own code and we prefer not to change third party code directly

Can do. However, there are 380+ image files in there, and the vast majority of them are not optimized.

plugins/Referrers/images/searchEngines/xx.gif maybe revert this file if it fails the test as i'm not sure why

Will do! Perhaps the optimizations performed on Gifs are too agressive for the tool(s) used by the checks.

@mattab commented on November 4th 2014 Owner

Can do. However, there are 380+ image files in there, and the vast majority of them are not optimized.

most of the images in libs/ are unused (eg. jquery themes)

@mattab commented on November 13th 2014 Owner

FYI we've now removed loads of fiels in bower_components (jquery UI themes).

@PierreLvx would you mind re-basing / updating the PR?

@PierreLvx commented on November 13th 2014

Cool! I totally forgot about this, will do by the end of the week.

Le 13 nov. 2014 à 06:11, Matthieu Aubry notifications@github.com a écrit :

FYI we've now removed loads of fiels in bower_components (jquery UI themes).

@PierreLvx https://github.com/PierreLvx would you mind re-basing / updating the PR?


Reply to this email directly or view it on GitHub https://github.com/piwik/piwik/pull/6571#issuecomment-62842724.

@mattab commented on December 18th 2014 Owner

Hi @PierreLvx I'm closing but feel free to reopen a Pull request! cheers

This Pull Request was closed on December 18th 2014
Powered by GitHub Issue Mirror