Target of this PR is to remove all duplicate reports from UserSettings plugin and migrate their data to DevicesDetection plugin (refs #3962)
What needs to be done:
@mattab would you mind having a look at the update script. Maybe there's an better/easier way to handle that
excellent change, working out some good technical debt.
Regarding the upgrade script, it's useful to return all the SQL to execute in the getSql() call, as admins will look at the SQL queries and then execute it manually.
Regarding backward compatibility could you check to maintain it:
I have decided to remove that os short labels completely. I don't think that they make any sense. There were around 15 short names defined, for the rest the long name was taken. DD currently detects > 60 os. So most of them would have been displayed in long.
I have decided to remove that os short labels completely.
+1 - we'll get to see in the screenshot tests all places that this impacts... also maybe static graphs in scheduled reports? either way, a good decision!
I'm done so far. Will do a translation cleanup after the merge.
@mattab could you do a last review? Feel free to merge if there's nothing wrong anymore
Nice streak... i'm merging! and going to run some tests on demo2