@mgazdzik opened this Issue on October 20th 2014 Contributor

I tried to use generate: tasks to scaffold plugin defining new reports and dimensions. Firstly I created dimensions, and then I tried to create report using those dimensions. I got following error:
"Leave dimension either empty or use an existing one. You can also create a new dimension by calling .console generate:dimension before generating this report."

After short investigation I think bug lies in this line
https://github.com/piwik/piwik/blob/master/plugins/CoreConsole/Commands/GenerateReport.php#L226

This loop doesn't notice newly created dimensions and therefore it's impossible to create report for it.
I think that loop should iterate over dimensions (columns?) themself instead of already existing reports.

I had enabled development options in config and cleared tmp/ directories so I don't think it's cache-related.

Or if it's false-positive let me know how to proceed with generating report for previously created new dimension.

@mattab commented on October 21st 2014 Owner

Thanks for the report! cc @tsteur

@tsteur commented on October 21st 2014 Owner

Can you check if it works?

BTW: In case development mode is enabled caches - should - be ignored anyway.

@mgazdzik commented on October 21st 2014 Contributor

@tsteur - yes it's working now, but still there is a minor flaw in generator use flow I think ;)
When scaffolding plugin user can generate dimensions, and reports without needing to activate plugin. However without activating plugin - dimensions defined by this specific plugin are not being recognized. Only after activating plugin they become available.
I think it would improve a bit feeling of scaffolding plugin using couple of CLI commands called one after another in row, without having to explicitly activating plugin which is 'not ready yet', what do you think ?

Lines to be possibly changed are:
https://github.com/piwik/piwik/blob/master/core/Plugin/Dimension/ActionDimension.php#L219
https://github.com/piwik/piwik/blob/master/core/Plugin/Dimension/ConversionDimension.php#L162
https://github.com/piwik/piwik/blob/master/core/Plugin/Dimension/VisitDimension.php#L282

@tsteur commented on October 21st 2014 Owner

Not sure. Maybe we could only include dimensions from this plugin you are currently working on / generating the report for? Even if it is deactivated? Guess this is the most common use case anyway

@mgazdzik commented on October 21st 2014 Contributor

Actually it would make even more sense that way. +1

This Issue was closed on October 21st 2014
Powered by GitHub Issue Mirror