@czolnowski opened this Pull Request on August 3rd 2014 Contributor

Add feature to persist cors hosts in config, edit in general settings tab and append to API headers if any is set.

@halfdan commented on August 3rd 2014 Member

Nice work!

@czolnowski commented on August 3rd 2014 Contributor

Thanks @halfdan!
@mattab: maybe there should be an issue to rewrite general settings screen into angular? It's pretty difficult to add there anything. (messing with jquery)

@mattab commented on August 3rd 2014 Owner

@czolnowski definitely, would be great to rewrite the settings in AngularJS... in the meantime, would you mind removing the new CORS settings? Instead we can add a new FAQ answer to explain to users. (it's nice to keep settings to minimum in the UI)

@czolnowski commented on August 3rd 2014 Contributor

So this settings shouldn't be available in settings, at all, yes?

@mattab commented on August 3rd 2014 Owner

So this settings shouldn't be available in settings, at all, yes?

:+1: (because it is used only rarely so far a FAQ answer is nice way to help user to configure it)

@mattab commented on August 4th 2014 Owner

@czolnowski applied my suggested changes in: https://github.com/piwik/piwik/commit/00ab57fb8a9b4bd2af400a204e9c96ecfa0b9afd

@halfdan I'm not sure if the comma separated notation really works. Did you test with setting two different cors_host entries?

This Pull Request was closed on August 3rd 2014
Powered by GitHub Issue Mirror