@craue opened this Pull Request on July 22nd 2014 Contributor

Another one. :smirk:

@halfdan commented on July 22nd 2014 Member

Hi @craue
Would you mind squashing down the commits into a single one?

@craue commented on July 22nd 2014 Contributor

@halfdan: Really? I separated them on purpose.

@sgiehl commented on July 22nd 2014 Member

Imho it is fine as it is. Every commit is fixing a different type.

@halfdan commented on July 22nd 2014 Member

@sgiehl In that case we can probably create a few hundred more commits.. I'd like to keep the history clean.

@sgiehl commented on July 22nd 2014 Member

Sure. But having more 'atomic' commits makes it easier to revert them if required. And it is easier to understand why something was changed.

@tsteur commented on July 23rd 2014 Owner

+1 for @sgiehl atomic commits.

@craue the tests fail as there were whitespace changes / newline changes in *.xml files. See https://travis-ci.org/piwik/piwik/jobs/30532901 . Would you mind undoing them? In our integration tests there are *.xml files generated and exactly compared with those files in the repository. If there is any whitespace different the tests fail. There are for instance some multiple newlines because we empty some lines in the comparison. For instances lines which contain a date.

@craue commented on July 23rd 2014 Contributor

@tsteur: Sure, I've excluded the tests/PHPUnit/Integration/expected folder and rebased the branch. Let's see if tests pass...

@tsteur commented on July 23rd 2014 Owner

Would you mind checking plugins/CustomVariables/tests/expected/, plugins/CustomVariables/tests/processed/, plugins/ExamplePlugin/tests/processed/ and plugins/ExamplePlugin/tests/expected/ as well?

@craue commented on July 23rd 2014 Contributor

Done, @tsteur.

@tsteur commented on July 25th 2014 Owner

Thx!

This Pull Request was closed on July 25th 2014
Powered by GitHub Issue Mirror