@anonymous-piwik-user opened this issue on July 10th 2008

On each request to the Dashboard I get several of the following errors:

"Non-static method Piwik_Visualization_OpenFlashChart::esc() should not be called statically, assuming $this from incompatible context"

The errors occur from the calls on lines 1277, 1289, 1295, 1301, 1302, 1427, 1439, and 1445.

The issue is that Piwik_Visualization_OpenFlashChart::esc() is an instance method even though it does not use or affect any instance state. As such, it should be a static method.

I've attached a patch that makes the method static and thus prevents all the error messages.

I understand that this is really an issue with OpenFlashChart, and am going to submit it there as well. However, I think it should be fixed here in the meantime so that the log files do not fill up with unnecessary noise.

@anonymous-piwik-user commented on July 10th 2008

Attachment: make_esc_static.diff

@mattab commented on July 21st 2008

thanks for reporting, fixed in [566]

This issue was closed on July 21st 2008
Powered by GitHub Issue Mirror