@mattab opened this issue on February 18th 2008

The main piwik code should validate XHTML / CSS. The CSS validation should be checked once all the CSS code is inside the CSS stylesheets. - XHTML = http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fpiwik.org%2Fdemo%2F%3Fmodule%3DHome%26action%3Dindex%26idSite%3D1%26period%3Dday%26date%3Dyesterday - CSS = http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=http%3A%2F%2Fpiwik.org%2Fdemo%2F%3Fmodule%3DHome%26action%3Dindex%26idSite%3D1%26period%3Dday%26date%3Dyesterday

The first logical step I can think of would be structure of templates for modularity - how do other successful open source projects handle their templates? - how to make it possible to add new themes?

see also #177

@mattab commented on March 9th 2008

XHTML transitional is enough. CSS version 2 is enough.

For this ticket the templates and CSS shouldn't be moved or changed more than needed to pass the validation. The patch should only be simple fix to ensure the validation is passed.

After the changes are done it is important to use the UI checklist to make sure everything is still working well.

Have you done some work on this ticket? thanks

@mattab commented on March 12th 2008

The idea was to simply validate the main index page and the XHTML templates, not the html generated and added with Jquery. This would be a first step :)

@mattab commented on June 12th 2008

milianw, I think I was not clear earlier, and I was sounding too pessimistic :) However I don't believe in "we'll fix this ticket" approach. This is a large ticket, too big actually.

The first logical step I can think of would be structure of templates for modularity - how do other successful open source projects handle their templates? - how to make it possible to add new themes?

Then once you come up with a clear idea on how to do things in a proper way: - organize the templates / CSS

Then only we could start fixing the xhtml issues. My point is that, because we have a bad file/logic templates structure, it's too early to start fixing problems.

If you guys want to be owner of this change, that would be very useful. Let me know!

@mattab commented on June 12th 2008

milianw , if there is discussion involved, it's better to post on the mailing list piwik-hackers. If there are pure findings and analysis, this ticket could do. Hope you can come up with good solution for managing piwik templating :)

@mattab commented on June 26th 2008

(In [525]) - improved echo output of DataTable (now showing user friendly output of datatable_Array) - refs #5628 hopefully fixed by limiting the number of levels in the Actions table hierarchy - refs #5544 started cleaning html code (patch by milianw)

@mattab commented on October 14th 2008

milianw, are you still interested to work on the css/xhtml improvements in Piwik? Let us know, thank you.

@mattab commented on May 18th 2009

all, if anybody would like to work on this please shout. In the meantime I close the ticket as this is not something we will roadmap as scope is not well defined at this stage. we would be glad to have a contributor investigating this issue though!

This issue was closed on May 18th 2009
Powered by GitHub Issue Mirror