@mattab opened this issue on February 11th 2008

See an example (second example) on http://www.ericmmartin.com/simplemodal/

@zawadzinski commented on April 22nd 2008

Attachment: feedback.patch

@zawadzinski commented on April 9th 2008

Working on this.

Apart from modal I will add a Piwik_Mailer class which is missing (I need it to solve #65 too).

@mattab commented on April 17th 2008

(In [mauser)- refs #5482 commited huge work by Maciej Zawadzi?\197?\132ski: thanks! still some work to do + QA but looks really good :) [mauser]- refs #5536 commited partial fix [mauser]- refs #5485 commited partial fix - fixed broken tests

@mattab commented on April 17th 2008

feedback: - similar to #65 we should test to make sure the email is sent. In this case, if the email cannot be sent for some reasons, we should show the message the user just typed and ask him to manually email us at hello@.. - the styles seem not defined, the input boxes are larger than the modal on my FF? - I suggest we have only the fields: Your email, Message. All these extra fields are a bit overkill in this case. - remove the "or esc Key" text - change the close text with an icon (for example http://www.iconfinder.net/iconlib/bnw/16x16/actions/stop.png) - make sure the font is georgia to be consisten with the rest of piwik - good job! :)

@zawadzinski commented on April 22nd 2008
  • close icon
  • check if email was sent
  • defined styles
@mattab commented on April 24th 2008

(In [mauser) - fixes #5536, font consistent, escape key now works [mauser] - fixes #5485, now catching error, printing friendly message, refactoring template code [mauser] - fixes #5482, fixing JS translations api, Piwik is now ready to be translated!!! :)

This issue was closed on July 23rd 2008
Powered by GitHub Issue Mirror