@nullnull-00 opened this issue on February 14th 2014

In Morpheus theme every second row of the tables in the security info page has white backgroud instead of green or yellow one. This makes it impossible to read text, which should have green background(due to the white font color).

The problematic css is

.dataTable tr:nth-child(2n) td {
    background-color: rgb(255, 255, 255) !important;
}

which overrides the inline css.

See attached screenshot!

@nullnull-00 commented on February 14th 2014

Attachment: white_tr.png

@nullnull-00 commented on February 15th 2014

Attachment: table.png

@hpvd commented on February 15th 2014
@hpvd commented on February 21st 2014
@hpvd commented on February 22nd 2014
@mattab commented on February 15th 2014

this looks fixed in latest SecurityInfo plugin and 2.1-rc1 please reopen if not!

@nullnull-00 commented on February 15th 2014

In my installation SecurityInfo-tables look even worse wit 2.1RC1, because all colors are gone now.

See the new screenshot.

@hpvd commented on February 15th 2014

same here. Put an other screenshot as attachment which highlights the problem a bit more...

@mattab commented on February 16th 2014

I'm using 2.1 RC1 and the latest securityInfo plugion from the marketplace and cannot replicate this issue. I'm confused that you are getting this with latest RC...

@hpvd commented on February 17th 2014

just installed again latest master piwik from github: everything look still the same with - firefox 28 and - opera 12.16

no new updates for plugins are shown/everything is up to date

PHP is v5.3.27

@mattab commented on February 18th 2014

In ca55552567cd3127b9658fe93e4d288b8e23d8ee: Refs #4682 Adding screenshot test for security info page, to see if we can replicate the bug on Travis

@mattab commented on February 18th 2014

as you can see here: http://builds-artifacts.piwik.org/ui-tests.master/1653.1/processed-ui-screenshots/UIIntegrationTest_admin_security_info.png

the screenshot looks ok even on travis.

Can you try delete the tmp/ folder of your Piwik?

@mattab commented on February 18th 2014

I released a new version of the Security Info plugin which I think will fix the issue! http://plugins.piwik.org/SecurityInfo

@nullnull-00 commented on February 18th 2014

Updated Piwik and the Plugin: Now everything works fine.

@hpvd commented on February 21st 2014

nearly fine ;-) the lines which are back again now have a different green colour...

please see attachment

@mattab commented on February 22nd 2014

Screenshot looks ok, what's the problem on it?

@hpvd commented on February 22nd 2014

hmm to different green font colours are used:

#9B7A44
#468847

=> is it a feature?

see new screenshot...

@nullnull-00 commented on February 22nd 2014

# 468847 is green("this setting is OK") -> previously green background

# 9B7A44 is red/brown("this setting is bad") -> previously yellow background

But I think the second color should be changed somehow, at the moment it looks more brown than red (which would fit better for the purpose of a probable security issue).

btw should there really be written

<em>disabled</em>

in allow_url_fopen ;)

@mattab commented on February 23rd 2014

Fixed in SecurityInfo 1.0.4 https://github.com/piwik/plugin-SecurityInfo/commit/ccd57664a99b997a75c0a1128d9a7c51390c45f7

This issue was closed on February 23rd 2014
Powered by GitHub Issue Mirror