@anonymous-piwik-user opened this issue on December 16th 2013

When I look at the widget 'visitors in realtime' the title tag is wrong when a goal is converted. It only shows the title text 'Visitor converted X Goals'. so when you put the mouse pointer on the '#' sign that tells the rank in the search engine, it still shows the title 'Visitor converted X Goals'.

The HTML code involved is:

<span class="visitorRank" title="Visit converted 1 Goals">
  <img src="plugins/Morpheus/images/goal.png">
  <span class="hash">#</span>
  1
</span>

Which will show the text 'Visit converted 1 Goals' even when I hover about the the search ranking text. See the attached image: WrongTitleInRealTimeVisitorsWidgetWhenGoalConverted.png

When there is no goal converted, the title texts are correct. Here is the HTML of it:

<span class="visitorRank" title="The keyword Keyword not defined was ranked #2 on the Google search result page for this visitor">
  <span class="hash">#</span> 2
</span>

And a screenshot called: RightTitleInRealTimeVisitorsWidgetWithOutGoalConverted.png

So I think this is a bug? The title text for the visitor rank should be placed on the span with the class 'hash'. And the goal text shoud be a title or alt tag of the goal png image. This way you can have more title tag for the different icons / options.

I would expect the following html

<span class="visitorRank" >
  <img src="plugins/Morpheus/images/goal.png" title="Visit converted 1 Goals">
  <span class="hash" title="The keyword Keyword not defined was ranked #1 on the Google search result page for this visitor">#</span>
  1
</span>

So in short: - Remove the text from the span with the class 'visitorRank' - Put the text for converted goals on the goal png image - Put the text for search enging rank on the span with the class 'hash'

I hope that it is clear what I mean to tell. And I hope that this can be fixed in an update. It is just a minor issue.

@anonymous-piwik-user commented on December 16th 2013
@anonymous-piwik-user commented on December 16th 2013
@mattab commented on December 25th 2013

This screenshot looks righT: http://issues.piwik.org/attachments/4383/WrongTitleInRealTimeVisitorsWidgetWhenGoalConverted.png

The #1 are on a different line. when in the top line, the #1 refers to goal conversion. When on the line below it refers to the position in the search engine result.

@anonymous-piwik-user commented on December 25th 2013

You are saying that the 'page rank' indicator is also the goal indicator? Is that not confusing? So how is that combined?

If they come from google, where it was the 3th link, and they hit my goal, it will say that the page rank is 1 where it should be 3...?

I would expect to see that the rank indicator is saying that it was the third result, and that they converted a goal. So that's why I expect the HTML code:

<span class="visitorRank" >
  <img src="plugins/Morpheus/images/goal.png" title="Visit converted 1 Goals">
  <span class="hash" title="The keyword Keyword not defined was ranked #1 on the Google search result page for this visitor">#</span>
  1
</span>

Else the page rank is always equal to the goal conversion, which is not correct in my opinion.

@mattab commented on December 25th 2013

sorry I dont understand what you dont understand. the screenshots look OK to me.

@anonymous-piwik-user commented on December 25th 2013

Ok,

ignore the screenshots. Look at the HTML code:

Current generated HTML is:

<span class="visitorRank" title="Visit converted 1 Goals">
  <img src="plugins/Morpheus/images/goal.png">
  <span class="hash">#</span>
  1
</span>

Which will always show the text 'Visit converted 1 Goals'. Even when I want to know the page rank. when I hover over the # sign, I expect a text like: 'The keyword Keyword not defined was ranked #1 on the Google search result page for this visitor' and not the text 'Visit converted 1 Goals' It does not do so.

Change the HTML to:

<span class="visitorRank" >
  <img src="plugins/Morpheus/images/goal.png" title="Visit converted 1 Goals">
  <span class="hash" title="The keyword Keyword not defined was ranked #1 on the Google search result page for this visitor">#</span>
  1
</span>

this way both the goal has the right title text as the page rank # has the right title text.

So, ignore my screenshots, en just look at the HTML code. It is not that hard to see the difference.

@mattab commented on December 26th 2013

There are two different #x displayed, they look the same but they are different. Basically if you convert goals AND if you come from google with the position then both #x and #y will show. It's a bit confusing but I think it's OK.

This issue was closed on December 26th 2013
Powered by GitHub Issue Mirror