@tsteur opened this Issue on November 28th 2013 Owner

Currently, events are posted to all loaded plugins, not all activated plugins.

This results for instance in including JavaScript files of deactivated plugins if merge_assets are disabled, it results in Fatal Errors if a deactivated plugin listens to events and produces a fatal error etc.

@tsteur commented on December 3rd 2013 Owner

In e3082f70733354fb4ea2c51cc11aa7eb6e01d792: refs #4357 post event only to activated plugins, fixed most fatals but still differences in output

@tsteur commented on December 3rd 2013 Owner

In 174bf3bbf151179c70f1c5d092e3006ae676b6c4: refs #4357 this should fix the core tests

@tsteur commented on December 3rd 2013 Owner

In aad58acbfa654b41f6866a18755591548e6bdb4d: refs #4357 this should fix some integration tests but not sure about the side effects

@tsteur commented on December 4th 2013 Owner

In 04326baa9745df0314a6ac8344b7ceea446cc890: refs #4357 post event only to activated and loaded plugins. Usually an activated plugin should be loaded anyway, but this seems not to be the case in tests where plugins are sometimes manually unloaded. Another solution would be to remove the plugin from activated plugins list ($pluginsToLoad) when unloadPlugin() is called. Not sure about side effects

@tsteur commented on December 4th 2013 Owner

In 71f18458b2e56188218032d48934a36851e9dfa3: refs #4357 fix more tests

@tsteur commented on December 4th 2013 Owner

In 034742afc2b29fa3d7953b933f1ceb040ec62188: refs #4357 make sure plugin name is set

@tsteur commented on December 4th 2013 Owner

In d323058db1fb70838f3a518e7e32ed70ccfe5cac: refs #4357 probably a better fix to make the integration tests working

@tsteur commented on December 4th 2013 Owner

In e3e45c79d2aa12538bb50a9e229aee0735bc8d4d: refs #4357 revert unloading plugins again, could not find another way to pass all the tests

@tsteur commented on December 4th 2013 Owner

Tests are green but not sure if it is safe to merge... See email

@mattab commented on December 9th 2013 Owner

made a change in master:

@mattab commented on February 1st 2014 Owner

@Thomas, thanks for the investigation. Could you check whether the problem is still found in Piwik, that events are posted to the disabled plugins? If so, i'd like to have this fixed.

Otherwise if the problem was fixed somehow, maybe we can close this ticket?

@mattab commented on March 3rd 2014 Owner

In f96c0f12e80428e912ba730f420da15ddd232ee4: Fixes #4357 Merging branch into master, let's see if the build stays green

@mattab commented on March 3rd 2014 Owner

In b6473579fd9de9d9860c62b1644b155370ca729e: Refs #4357 Not fully working, so reverting

@mattab commented on April 7th 2014 Owner

In e6ffa98614f15e9ce7e195f0dbd50f73736e2b26: Refs #4357 only post events to activated plugins.
ticket is not fixed because I think other calls to getLoadedPlugins() should maybeu use this new function getPluginsLoadedAndActivated() instead.

@mattab commented on April 7th 2014 Owner

In 4c9d0c375bf7c215a05a4c5ab7f70ec152f0b4fa: A proper hack to be removed soon ummmmmmok? Refs #4357

@mattab commented on April 12th 2014 Owner

In bc195031d14038ba37a4bbc49ceda919c7ef4bfe: Refs #4357 let's see how build behaves with this change?

@mattab commented on April 12th 2014 Owner

Fixed and tests are now passing. Had to resort to hacks to make them pass on travis https://github.com/piwik/piwik/commit/f94ea2e1bfec2511f9ace7db72b71ef948de85da

@mattab commented on April 14th 2014 Owner

In ab2e09e9f5538d50c0ce9ea6061263d47670fff5: Refs #4357 Only add Javascript and CSS files from activated plugins.

@mattab commented on April 14th 2014 Owner

In 7f59bbbf0de34a119eefc356ba09d41c03540091: Revert previous commit, this was wrong. Instead use: getPluginsLoadedAndActivated() to load only activated plugins. refs #4357

This Issue was closed on April 14th 2014
Powered by GitHub Issue Mirror