@diosmosis opened this Issue on July 8th 2013 Member

Related to #1491.

Should be possible to define a set of display properties for a report and have ViewDataTable automatically render based on those properties. This would replace the current method of manually creating a ViewDataTable instance and calling setXXX and disableYYY functions on it before rendering.

@anonymous-piwik-user commented on July 12th 2013

In 01057779046dd67923bd34d123628ab60ed263bc: Refs #4040, #4041, move all ViewDataTable properties to the viewProperties array and allow these properties to be specified through new display metadata. Converted the Actions, Goals, UserSettings and VisitTime controllers.

Notes:

  • Includes refactoring of ExcludeLowPopulation filter.
@anonymous-piwik-user commented on July 28th 2013

In d99e37ebc3e98f8eae1a043eb9f94e0a4aa43c9a: Refs #4040, Modify getReportDisplayProperties to add display properties for all of a plugin's reports to a list rather than to pick out the display properties for a single report.

@anonymous-piwik-user commented on July 28th 2013

In 80c4b4604020201d3fff0f232f6fff824ab1cb9b: Refs #4040, converted CustomVariables plugin to use display properties instead of manually calling ViewDataTable functions.

@anonymous-piwik-user commented on July 28th 2013

In d056230d5f20dbe028aaf69b512f89f273027b25: Refs #4040, converted DBStats plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 28th 2013

In a5bbfbf9bc18d29f0aad91e3a67c70d2736f93f5: Refs #4040, convert DevicesDetection plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 28th 2013

In 9b02615d4fc941b6267d482c047a60e266ab404c: Refs #4040, move Piwik_ViewDataTable::getRawSegmentFromRequest to Piwik_API_Request.

@anonymous-piwik-user commented on July 28th 2013

In f1dcb45b39484d16b515fdb17057ceeff36a0a3d: Refs #4040, converted Live plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 28th 2013

In b29898398780153f7abcba351e0a24c4275bd8c1: Refs #4040, convert Provider plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 28th 2013

In 02e0be4ba9cb91da4f5146995f1cb76f0f867f24: Refs #4040, converted Referrers plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 29th 2013

In 4e3a67a45837e0a4cdb4eddee228640aa89dcbbf: Refs #4040, converted UserCountry plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 29th 2013

In 228a6aa7683469505f17f9804f0372552f821ed3: Refs #4040, converted VisitorInterest plugin to use display properties instead of ViewDataTable methods.

@anonymous-piwik-user commented on July 30th 2013

In edf2c04f41445fb6f3f5658e887b53a8a49b4e13: Refs #4040, #4041, added ability to access view properties directly, started documenting view properties and modified ExampleUI plugin to set view properties directly.

@anonymous-piwik-user commented on July 30th 2013

In 0ea1a94655bb441b832b118904b65bdfd72766fc: Refs #4040, #4041 convert RowEvolution popup rendering code to set view properties directly.

@anonymous-piwik-user commented on July 30th 2013

In 13f657ccfa6b58864291a173a0849d7169b031b2: Refs #4040, #4041, fix sparklines regression caused by datatable css refactoring and clean up the getLastUnitGraphAcrossPlugins function (modified to set properties directly).

@anonymous-piwik-user commented on August 1st 2013

In 0f61caac0d97e28ac7653078c6d1b7bf09cd4bab: Refs #4040, #4041 removed rest of viewdatatable set/get/enable/disable property functions, did the same for all other ViewDataTable classes, moved most of ViewDataTable/HtmlTable logic to visualization instead of main class and re-add links for UI integration tests.

@anonymous-piwik-user commented on August 1st 2013

In 883c3228e03e4e93e5338fa1f3ad18a6aaaa65ea: Refs #4040, #4041, move more logic out of HtmlTable ViewDataTable class.

@anonymous-piwik-user commented on August 3rd 2013

In 1a9898be75d875132ff09e94c08b6d8114767aee: Refs #4040, #4041, fix regression in default sort column of goals table.

@anonymous-piwik-user commented on August 3rd 2013

In 7519e6734ae0ccc740d9ff52c6835bdf7d119f6d: Refs #4040, #4041, move AllColumns ViewDataTable & Goals ViewDataTable logic to HtmlTable visualization class & remove those classes. Revised the way visualizations default/override view properties. Cleaned up the ViewDataTable class a bit. Added base type for datatable visualizations.

@anonymous-piwik-user commented on August 3rd 2013

In b80848961f49c75249f2992d17e14fc2c5012071: Refs #4040, #4041, remove is_multi_evolution javascript parameter as it is no longer necessary due to earlier row evolution refactoring.

@anonymous-piwik-user commented on August 3rd 2013

In cc92fac0339044aef75c8395e394f3a1a79aa646: Refs #4040, #4041, remove GenerateGraphHtml & descended ViewDataTables and replace w/ new visualizations for jqplot.

@anonymous-piwik-user commented on August 3rd 2013

In ac3a25c3784dfc099c93b53848cf00302766ce7e: Refs #4040, #4041, forgot to remove GenerateGraphHTML file.

@anonymous-piwik-user commented on August 6th 2013

In cf8d0a51591e39ecf8aa8f4c09b5672ec2d312cd: Refs #4041, #4040, moved viewdatatable cloud logic to cloud visualization. Removed cloud viewdatatable.

@anonymous-piwik-user commented on August 6th 2013

In 2615404eab2e96048583caccf86248af2dd90d9b: Refs #4040, #4041, move visualization only view properties to separate visualizations, changed JavaScript properties to 'client side parameters' and 'overridable properties' to 'client side properties', changed keep_summary_row from a JavaScript property to a client side property, allowed visualization properties to be inherited, fixed system that allowed visualizations to set custom defaults for property values, modified behavior of datatable_css_class viewdatatable property, allow view properties to be customized in metadata based on the visualization used, and tweaks to UI Integration tests.

@anonymous-piwik-user commented on August 6th 2013

In 9b5a42a62395607556893085701a8d385c464697: Refs #4040, #4041, change the way jqplot.js checks for viewdatatble types, changed relatedReports view property name to related_reports and fixed spelling of row_picker_mach_rows_by.

@anonymous-piwik-user commented on August 6th 2013

In e898bc2998e672f76defd8b7a996865b759d1aa4: Refs #4040, #4041 add initial code for making datatable visualizations an extensibility point.

@anonymous-piwik-user commented on August 6th 2013

In 9e19f249150a142b5fe97e96175beb847323862c: Refs #4041, #4040 add new CoreVisualizations plugin and move HtmlTable, Cloud & JqplotGraph visualizations to it and improve UIIntegration test debug output.

@anonymous-piwik-user commented on August 6th 2013

In be35dc408c539892d201bcda65e03d099f529128: Refs #4040, #4041, removed ViewDataTable::init & moved default property values for core properties to Properties class.

@anonymous-piwik-user commented on August 6th 2013

In 7daadd45d61228131a805569e145f3bd4228b604: Refs #4040, #4041 added new plugin ExtraVisualizations with dummy visualization and made it possible for non-core visualizations to appear in DataTable UI footer.

@anonymous-piwik-user commented on August 6th 2013

In 6f8b40d75e202b4e42682be4538747bcfc31d8a2: Refs #4040, #4041, added documentation to DataTableVisualization class.

@anonymous-piwik-user commented on August 6th 2013

In 27dcd700926b3a7011b44fce21be2814f5032a29: Refs #4040, #4041, removed two-phase rendering for ViewDataTable.

@diosmosis commented on August 6th 2013 Member

Done.

@mattab commented on August 9th 2013 Owner

Nice work and refactoring! we will discuss with team their opinion and where we can take it next. Keep it up!

This Issue was closed on August 9th 2013
Powered by GitHub Issue Mirror