@anonymous-piwik-user opened this Issue on June 6th 2013

piwik.js

change:

define(["piwik"],[],

to:

define("piwik",[],

The module name should not be wrapped in brackets. It should be passed as a string; not an array.
Keywords: define amd

@robocoder commented on June 8th 2013 Contributor

In 0858888bba21a092839a6740a96aaa6ea4748a21: fixes #3975

@robocoder commented on June 8th 2013 Contributor

In 98adc6a64c75dbc28c9bbe227d39d14e810d612a: fixes #3975

@anonymous-piwik-user commented on June 10th 2013

This issue breaks existing websites that use RequireJS when Piwik is loaded async (which it is by default).

Uncaught Error: Mismatched anonymous define() module: 
http://requirejs.org/docs/errors.html#mismatch require.js:160
makeError require.js:160
intakeDefines require.js:1191
(anonymous function)

When piwik.js is evaluated before require.js, this stops loading other modules, instead of giving only an error.

Perhaps it is a good idea to release Piwik 1.12.1 with the provided fix?

@robocoder commented on June 10th 2013 Contributor

Already committed to the 1.x maintenance branch.

@anonymous-piwik-user commented on December 5th 2013

bug still present in current 1.12 - had to patch manually

@mattab commented on December 10th 2013 Owner

Can you confirm it works in 2.0 ? https://piwik.org/blog/2013/10/new-piwik-2-0-public-beta-for-testers/

If not please suggest how to fix it, cheers

@anonymous-piwik-user commented on December 11th 2013

It's fixed. Thanks.

This Issue was closed on December 11th 2013
Powered by GitHub Issue Mirror