@tsteur opened this Issue on April 9th 2013 Owner

When opening the Referers.getAll evolution graph I'm getting the following error message:

API returned an error. Referers.getAll with multiple sites or dates is not supported (yet).

Link to reproduce:
http://demo.piwik.org/?module=API&method=ImageGraph.get&idSite=7&period=day&date=last7&apiModule=Referers&apiAction=getAll&outputType=0&showLegend=1&fontSize=9&aliasedGraph=1&legendAppendMetric=1&format=JSON&token_auth=anonymous

Link to file:
https://github.com/piwik/piwik/blob/master/plugins/Referers/API.php#L113

To fix this issue, Referrers.getAll should either support multiple dates/websites or MetadataAPI should not return an imageGraphEvolutionUrl for this report, see:

http://demo.piwik.org/?module=API&method=API.getProcessedReport&idSite=7&period=day&date=today&apiModule=Referers&apiAction=getAll&showTimer=1&format=JSON&token_auth=anonymous

@mattab commented on April 20th 2013 Owner

+1 for "MetadataAPI should not return an imageGraphEvolutionUrl for this report"

@mattab commented on May 23rd 2013 Owner

In 2d5b0aca2c0bbbe0f740182134c0162b11466fd2: Fixes #3887
Hiding row evolution graph URL from output for Referrer.getAll
Please double test it's all working!

@julienmoumne commented on May 25th 2013 Member

I am not sure this is right.

'constantRowsCount' = 1 means there are a constant number of rows, ie. Piwik websites.

This is not true.

I suggest the imageGraphEvolutionUrl metadata entry be left empty in http://git.piwik.org/piwik.git/blob/master/plugins/ImageGraph/ImageGraph.php#L46 by using a static list of excluded reports.

@julienmoumne commented on May 25th 2013 Member

This explains why you had to update an image in an integration testing file :https://github.com/piwik/piwik/commit/2d5b0aca2c0bbbe0f740182134c0162b11466fd2#diff-1

This image should not have changed since it is not an evolution graph.

@mattab commented on May 26th 2013 Owner

In 70b46eceba318a55d17d4aee0cb03eddb90e5d2c: Fixes #3887
Proper fix for this problem, adding static array of "Row evolution not supported"

Also I decided to enable tests so they all run on my box /standard ubuntu, rather than travis CI.
Fixed a bug in tests that plugins language files were not loaded early enough.

@mattab commented on May 26th 2013 Owner

Of course you were right Julien +1

This Issue was closed on May 26th 2013
Powered by GitHub Issue Mirror