@sgiehl opened this Issue on February 3rd 2013 Member

Browser language setting is already tracked for every visitor.
That data should also be available within the frontend.

@halfdan commented on February 4th 2013 Member

I agree that this is interesting. Right now though, we don't even store the data in the 1st normal form (e.g. de-de,de,en-us,en).

Sometimes we have multiple occurences of the same language, e.g. de-de,de,en-us,en - which one is important here? de-de or de? Are they the same? What about en, en-gb and en-us?

What is important here? Should we just count the first language or all in the list? Should we build multiple statistics like "First Browser Language", "Second Browser Language"?

Ideas?

@sgiehl commented on February 4th 2013 Member

I guess the main language should be enough for most users.
Btw. I'm already on that. Guess I'll finish that by the end of the week...

@halfdan commented on February 4th 2013 Member

Ah nice! Good to know, almost started with it myself :)

@mattab commented on February 4th 2013 Owner

Only first language of the list, to keep things simple I think.

We could alternatively look at secondary languages if the first one is en-us for example, because I know lots of browsers ship by default with en-us settings and users don't necessarily change it.

@sgiehl commented on February 10th 2013 Member

In 3f490380e4b54048d525ca10df2d5bd1a11d147e: refs #3726 adding reports for browser language of visitors

@sgiehl commented on February 10th 2013 Member

In d1546c522c113634040c35cfddba9acb36477fcf: refs #3726 small test for method to get language from browser setting

@sgiehl commented on February 10th 2013 Member

In abce17aca839cbc6d3d92764168b3013f8b6d77b: refs #3726 fixing test

@sgiehl commented on February 10th 2013 Member

In b2aeb6a276d2b641dc320488b0e0c7e83dbefef3: refs #3726 added language names to translations

@sgiehl commented on February 10th 2013 Member

In 74ff8ea4d5af124f1c9502756ddf57a665d11883: refs #3726 small improvements to detection method

@sgiehl commented on February 10th 2013 Member

In e29d059e63d2ee0882c9e75b338ffcdbd9db9ef4: refs #3726 fixing some integration tests

@halfdan commented on February 10th 2013 Member

Thanks! :-) I was scratching my head for the last 5 minutes and wondered why tests were suddenly failing on Travis..

@sgiehl commented on February 10th 2013 Member

In 952dbcdfb40d45b901d22dc56b5242fa1dc6c3ec: refs #3726 fixing integration test files

@mattab commented on February 11th 2013 Owner

Very nice changes!

Code review:

  • Some of the new code in: Piwik_UserSettings::_getLanguageCodeFromBrowserSetting
    is redundant with existing code in: Piwik_Common::extractCountryCodeFromBrowserLanguage
    I think both should use same logic ?
@mattab commented on February 11th 2013 Owner

In 2826710d25b72fe2d6e1fcc6c1892651db0f0f98: small refactor refs #3726

@sgiehl commented on February 12th 2013 Member

In 09bddedbe37c9d6bc01df960105852cf58d43777: fixes #3726 use Piwik_Common::extractLanguageCodeFromBrowserLanguage instead of new method to get language code

This Issue was closed on February 12th 2013
Powered by GitHub Issue Mirror