@kodeaffe opened this Pull Request on March 1st 2013

maybe it's less invasive this time, setting timezone = 0 if GMT .

also, i looked again at expressjs' output and improved the format regex

@mattab commented on March 2nd 2013 Owner

reopening to re-trigger build

@mattab commented on March 2nd 2013 Owner

unfortunately fails the build: https://travis-ci.org/piwik/piwik/jobs/5176201

so maybe it's causing a regression. You can run the test with "phpunit Integration/ImportLogsTest.php" in the tests/PHPUNIT directory

@halfdan commented on March 2nd 2013 Member

@marmorkuchen Can you please check why the tests are failing and provide a fix?

@kodeaffe commented on March 4th 2013

sorry, i am not keen to setup apache + PHP on my localhost to run the tests.

i looked at the failing tests on https://travis-ci.org/piwik/piwik/jobs/5176201, but i am seriously lacking domain-specific knowledge. this looks like translation issues and other mismatches in parsed xml templates.

@mattab commented on March 4th 2013 Owner

similarly, we are not keen to debug your code and fix it for you (note: it does break the build and has a bug)

This Pull Request was closed on March 2nd 2013
Powered by GitHub Issue Mirror