@BrainCrumbz opened this issue on January 18th 2013

In the Log component, addWriteToFile method, as in: https://github.com/piwik/piwik/blob/master/core/Log.php#L56

the set formatter is $this->screenFormatter.

Shouldn't that be $this->fileFormatter instead?

@mattab commented on January 18th 2013

it probably should indeed. Have you used it or just noticed it? we'll investigate

@BrainCrumbz commented on January 21st 2013

We've used that during some debug session. After the switch, we saw an output change from:

CACHE_CONTROL: max-age=0\r\nCONNECTION: keep-alive\r\n<br/>

to:

CACHE_CONTROL: max-age=0 CONNECTION: keep-alive

So the &lt;br/> disappeared, but the \r\n were not replaced with actual carriage returns.

@mattab commented on February 4th 2013

In 05de97edb5c92c86b2eb57439a55db86b371c1c7: Fixes #3690 Thanks for the report & patch!

This issue was closed on February 4th 2013
Powered by GitHub Issue Mirror