@lesensei opened this Pull Request on February 26th 2013 Contributor
@halfdan commented on February 26th 2013 Member

@lesensei Nice! Can you please add a test to this? See the tests/ and tests/logs directory.

@lesensei commented on February 26th 2013 Contributor

@halfdan well, I might be able to do that (although I only have a production install at the moment, so I might not be able to actually run the tests). In any case, I can't find the tests/logs directory. The only thing related to logs I am able to find is the tests/resources directory. I can provide a fake log file for this, but could you point to an actual test of the "log importing" feature ?

@halfdan commented on February 26th 2013 Member
@lesensei commented on February 26th 2013 Contributor

@halfdan I added an utterly fake s3 log file for the log format test :-) Do you want me to add a test similar to test_replay_tracking_arguments for a sample s3 log file as well ?

@lesensei commented on February 26th 2013 Contributor

Ah, I guess not, nevermind my last comment :-) Thank you.

@halfdan commented on February 26th 2013 Member

Thanks for the log file - I'll make sure tests work. Great to have something for S3 now!

This Pull Request was closed on February 26th 2013
Powered by GitHub Issue Mirror