@anonymous-piwik-user opened this Issue on May 16th 2012

I have a goal tracking clics on an external link which downloads a file. The filenames can have special characters like "spaces".

The goal is set with the encoded URL copied directly from the site like "my%20file%20link.pdf". With this encoded filename, the goal is never converted. With the non-encoded filename like "my file link.pdf", it's converted.

Maybe Piwik should handle this use case and convert goals even with encoded URLs.

@robocoder commented on May 16th 2012 Contributor

No. Apache/PHP already does a decode for %xx. If we do another decode, we make it harder to specify literal %xx. It could also inadvertently provide hackers with a method to bypass filters like mod_security.

At best, we could add some JavaScript to the forms that would warn if the URL appears to contain encoded characters and offer to decode on the client side before submitting.

@mattab commented on October 19th 2012 Owner

see related #3549

@mattab commented on March 16th 2014 Owner

Let's try to reproduce to see if this bug still applies.

See also related #3863

@mattab commented on April 9th 2015 Owner

it's a 2.5 year old bug and this time decided to tackle it and it took 20min

This Issue was closed on April 9th 2015
Powered by GitHub Issue Mirror