@simonschaufi opened this Pull Request on February 15th 2013 Contributor

Mozilla Thunderbird with User Agent "Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120614 Thunderbird/13.0.1" is currently shown with the red Mozilla lizard icon, instead of the blue(ish) icon of Thunderbird, and it will be shown as "Mozilla 13.0" instead of "Thunderbird 13.0". (Unlike Firefox, which is shown as "Firefox 13.0" with respective Firefox icon.)

@robocoder commented on February 15th 2013 Contributor

Please add a test case to piwik/tests/PHPUnit/Plugins/UserSettingsTest.php.

@simonschaufi commented on February 15th 2013 Contributor

it't not my fault that the global tests are not passing. fopen(/home/travis/build/piwik/piwik/tests/lib/geoip-files/GeoIPISP.dat): failed to open stream: No such file or directory

@halfdan commented on February 15th 2013 Member

No that is not your fault, we are currently working trying to resolve the issues with the Travis-CI build.

@simonschaufi commented on February 15th 2013 Contributor

i don't know how many useragents are enough, i could add some more if needed.

@halfdan commented on February 15th 2013 Member

I'll add some more tests - thanks for your pull request!

@simonschaufi commented on February 16th 2013 Contributor

you're welcome! it was my first one ;)

i would prefer tabs instead of spaces in the unit tests. the rest of the files also use tabs. can you please change that? i just didnt want to change the whole file at once mixing up 2 things.

@halfdan commented on February 16th 2013 Member

I'll put it on my list, I never noticed that to be honest. It might not happen very soon, but I think there should definitely be same code styles when we come closer to Piwik 2.0.

Feel free to work on other things as well, we've got quite a number of tickets still unresolved: dev.piwik.org

This Pull Request was closed on February 15th 2013
Powered by GitHub Issue Mirror