@Solfire opened this Pull Request on November 22nd 2013

This update provides detecting TVs with the DevicesDetection plugin based on the UserAgent.

  • Adding most common TV brands
  • Adding icons for new added TV brands
  • Adding ANTGalio Browser and ANT Browser familiy
  • Adding Opera Next Browser (Blink Engine)
  • Adding televisionRegexesFile
  • Adding getTelevisionRegexes()
  • Adding parseTelevision()
  • Adding isTelevision()
  • Adding televisions.yml with TV regexes
  • Modify parse()
  • Modify parseBrand()
  • Modify parseModel()
  • Update userAgentParserEnhancedFixtures
  • Update some brand icons

Testet with several devices (see picture attached):

update

@Solfire commented on November 22nd 2013

This is the 2nd try ...

@mattab commented on December 9th 2013 Owner

looks like a very good change to add TV detection!

To prepare better I made some improvements in the test fixtures format: https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Fixtures/userAgentParserEnhancedFixtures.yml with the new "device" category.
and also optimization in https://github.com/piwik/piwik/commit/49e77d925298edf87c8f019a47eb6bf597be3c0f
and some message to help with easily updating the list of expected fixtures (so it's easier to edit the list of fixtures)

In fact i'm thinking we should split the test fixture file in separate files per device type or so...

Would you mind updating the PR to latest master? and see if Travis is green (it is now)

Looking forward to include it in Piwik :+1:

This Pull Request was closed on November 22nd 2013
Powered by GitHub Issue Mirror