@halfdan opened this Issue on May 11th 2010 Member

I saw that core/Access.php has lots of strings that are not getting translated. This should be fixed.
Keywords: translation

@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member

Attachment:
core.Period.patch

@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 23rd 2010 Member
@julienmoumne commented on May 24th 2010 Member
@julienmoumne commented on May 24th 2010 Member
@julienmoumne commented on May 24th 2010 Member
@julienmoumne commented on May 24th 2010 Member
@julienmoumne commented on May 30th 2010 Member
@julienmoumne commented on May 30th 2010 Member

Attachment:
1351.patch

@julienmoumne commented on May 30th 2010 Member
@robocoder commented on May 11th 2010 Contributor

Yes, lots of exception string messages to translate...

@mattab commented on May 13th 2010 Owner

Yeah let's rename this ticket to include all Exception or error messages (displayed to the user screen) yet to be translated.

@julienmoumne commented on May 23rd 2010 Member

I propose to do it file by file. Here is core/API/Proxy.php

@julienmoumne commented on May 23rd 2010 Member

Please advise on message key string for exception /core/Archive/Array/IndexedBySite.php#111 :

throw new Exception("Piwik_Archive_Array_IndexedBySite::getDataTableFromNumeric() algorithm won't work if data is stored in different tables");
@julienmoumne commented on May 23rd 2010 Member

do not consider file core.DataTable.Renderer.2.patch

@julienmoumne commented on May 23rd 2010 Member

Please advise on message key string for exceptions :

/core/SmartyPlugins/function.loadJavascriptTranslations.php#37 :

throw new Exception("The smarty function loadJavascriptTranslations needs a 'plugins' parameter.");

/core/SmartyPlugins/function.postEvent.php#34 :

throw new Exception("The smarty function postEvent needs a 'name' parameter.");

/core/SmartyPlugins/modifier.money.php#22 :

throw new Exception('the smarty modifier money expects one parameter: the idSite.');
@mattab commented on May 24th 2010 Owner

Julien, thanks for the patches - can you please submit one patch that contains all changes?

Otherwise, there are many exception messages that don't need to be translated, as they are never displayed on screen (or when they are, this is not an expected error and it doesn't need to be translated).

Example of exceptions that should never display on user screen (unless a plugin is buggy, or something else went very wrong) and therefore don't need to be translated:

  • 'General_ExceptionInvalidInputDate'
  • 'General_ExceptionSubtableAlreadyAssociated'
  • 'General_ExceptionRSSFeedInvalidDataTable'
  • 'General_ExceptionIDArchiveNull'
  • 'General_ExceptionInvalidAPI'
  • etc.
    Also I didn't find General_ExceptionMysqliCharsetFailed in the code?

Basically all exceptions that we translate should not mention 'code specific' issues and should let the user know, in non technical terms, what the error is and why it happened. Let me know if that makes sense

@mattab commented on May 24th 2010 Owner

Replying to JulienM:

Please advise on message key string for exceptions :

/core/SmartyPlugins/function.loadJavascriptTranslations.php#37 :

throw new Exception("The smarty function loadJavascriptTranslations needs a 'plugins' parameter.");

/core/SmartyPlugins/function.postEvent.php#34 :

throw new Exception("The smarty function postEvent needs a 'name' parameter.");

/core/SmartyPlugins/modifier.money.php#22 :

throw new Exception('the smarty modifier money expects one parameter: the idSite.');

these strings don't need to be translated as they would not appear on screen except during the development of a plugin (and in this case, it's OK to show english to the dev)

@julienmoumne commented on May 30th 2010 Member

Patch 1351.patch externalizes exceptions marked in translated-exceptions.html

@mattab commented on May 31st 2010 Owner

(In [2246]) Fixes #1351 All error messages displayed to screen/API should not be translated. Thanks JulienM for patch!

I simply refactored the 'you must be have %s access [...]' messages by putting the admin/view/superuser as a parameter in the string

This Issue was closed on May 31st 2010
Powered by GitHub Issue Mirror