@halfdan opened this issue on May 11th 2010

Collecting missing search engine favicons here. Keywords: favicon

@halfdan commented on May 11th 2010
@halfdan commented on May 11th 2010
@halfdan commented on May 11th 2010

Attachment: hooseek.com.png

@halfdan commented on May 14th 2010

Attachment: Script to fetch missing and list not needed favicons. ProcessFavicons.zip

@halfdan commented on May 14th 2010

Attachment: Favicons + List of not needed favicons Favicons.zip

@robocoder commented on May 11th 2010

halfdan: will you be able to go through the entire list (core/DataFiles/SearchEngines.php and plugins/Referers/images/searchEngines)?

p.s. Looks like mserv.rrzn.uni-hannover.de.png is deprecated by above and can be removed.

@mattab commented on May 11th 2010

we don't need to put icons from the full list, as most search engines are very rarely used, and this would increase the archive size.

@halfdan commented on May 11th 2010

matt: alright vipsoft: Sure, I'd just write a script to fetch all favicons.

The icons above are just those that were missing in my/the piwik demo stats.

@robocoder commented on May 11th 2010

I count ~230 entries in core/DataFiles/SearchEngines.php, and ~195 files in plugins/Referers/images/searchEngines. So, about 35 missing icons. If the average icon is .5K, I think we can afford an extra 18K added to the archive size.

(BTW we can free up 464K by not including "libs/jquery/original lib" in the archive.)

@mattab commented on May 11th 2010

Anthon, good point regarding "libs/jquery/original lib"; can you delete it and add in a REAMDE file what the files are (if there are special things to know about them)

Also OK I didn't realize that most icons were already in there.

@halfdan commented on May 11th 2010

Alright, assign me this ticket - I'll add the missing favicons.

@halfdan commented on May 12th 2010

Just to be sure: The favicon name is the url + .png of the first appearance of a search engine in core/DataFiles/SearchEngines.php?

In that case I have 82 new favicons and a list of 36 favicons that can be removed because of redundancy.

@robocoder commented on May 17th 2010

(In [2190]) fixes #1350 - add missing icons and remove redundant icons; contributed by halfdan; p.s. nice script

This issue was closed on May 17th 2010
Powered by GitHub Issue Mirror